[#77] Fix: wrong active category #72
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix preview emoji
Add native emoji index
Because, when used in slot, we can't resend the event to picker component.
Example:
render(h) {
return (
<div class="emoji-mart-holder">
<div class="emoji-mart-body">
</div>
{
<Picker
scopedSlots={{
previewIdleTemplate: slotProps => {
return [
<div>
<div class="emoji-mart-preview-skins">
// Here we do this.$emit('change', $event), but the Picker component
// will not get that, as we are in the external slot
<Skins skin={ slotProps.skinProps.skin }
onChange={ $event => this.$emit('change', $event) } />
// Here we call the callback directly:
<Skins skin={ slotProps.skinProps.skin }
onChange={ $event => slotProps.onSkinChange($event) } />
</div>
</div>
]
}
}}
onSelect={this.selectEmoji}
title="Pick your emoji..."
emoji="point_up" set="emojione"
perLine={this.perLine}
/>
}
</div>
</div>
);
// And we can do the same in the default content of the Preview component,
// call the onSkinChange directly instead of passing the 'change' event:
- <skins :skin="skinProps.skin" @change="$emit('change', $event)" />
+ <skins :skin="skinProps.skin" @change="onSkinChange($event)" />
Started with the granular slots (inside the Search / Preview components), but it appears that fallback content is not rendered in the nested slots in vue 2.5. It works in 2.6 and should be further improved in 3.0, see vuejs/vue#7765 (comment)
High level scoped slots
Update build scripts, update json data.
Removed: emojione (JoyPixels request) and messenger (unified into facebook) sets. Replaced 'Smileys & People' category with 'Smileys & Emotions' and 'People & Body'.
[#62] emoji v12
[#68] Fix visible edges of nearby sprite icons
[#74] Fix emoji skin property
I am not sure about the fix as it depends on virtual scroller inernals. It looks like before, the `endIndex-1` expression worked well while now it is `endIndex-2`, although I din't really know if that is always the case.
|
Wrong base. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[#77] Fix: wrong active category (the next category is highlighted as active, not the current one).