-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 0.1.0 #11
Release 0.1.0 #11
Conversation
But leave `in_callback` as that will likely be used soon.
@@ -1,4 +1,6 @@ | |||
# libevent-rs | |||
[![](https://meritbadge.herokuapp.com/libevent)](https://crates.io/crates/libevent) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've never seen meritbadge, I've always used shields.io. Are there any pros/cons to one vs the other?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just copy-pasta'ed from the libevent-sys
README for laziness consistency. And looking at my other crates, some use shields.io while others use meritbadge, so there's really no distinct reasoning behind the choice. Probably good just to pick one and stick with it though 🤷
@@ -1,4 +1,6 @@ | |||
# libevent-rs | |||
[![](https://meritbadge.herokuapp.com/libevent)](https://crates.io/crates/libevent) | |||
[![Released API docs](https://docs.rs/libevent/badge.svg)](https://docs.rs/libevent) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another useful badge is the MSRV: ![Minimum rustc version](https://img.shields.io/badge/rustc-1.42+-lightgray.svg)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made #12 to track this. As a sidenote, while looking for authoritative references for this I found rust-lang/rust#65262 which seeks to allow declaring MSRV directly in the Cargo.toml
, pretty cool.
No description provided.