Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.1.0 #11

Merged
merged 3 commits into from
Aug 19, 2020
Merged

Release 0.1.0 #11

merged 3 commits into from
Aug 19, 2020

Conversation

jmagnuson
Copy link
Owner

No description provided.

But leave `in_callback` as that will likely be used soon.
LICENSE-MIT Outdated Show resolved Hide resolved
@@ -1,4 +1,6 @@
# libevent-rs
[![](https://meritbadge.herokuapp.com/libevent)](https://crates.io/crates/libevent)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've never seen meritbadge, I've always used shields.io. Are there any pros/cons to one vs the other?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just copy-pasta'ed from the libevent-sys README for laziness consistency. And looking at my other crates, some use shields.io while others use meritbadge, so there's really no distinct reasoning behind the choice. Probably good just to pick one and stick with it though 🤷

@@ -1,4 +1,6 @@
# libevent-rs
[![](https://meritbadge.herokuapp.com/libevent)](https://crates.io/crates/libevent)
[![Released API docs](https://docs.rs/libevent/badge.svg)](https://docs.rs/libevent)
Copy link
Collaborator

@nastevens nastevens Aug 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another useful badge is the MSRV: ![Minimum rustc version](https://img.shields.io/badge/rustc-1.42+-lightgray.svg)

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made #12 to track this. As a sidenote, while looking for authoritative references for this I found rust-lang/rust#65262 which seeks to allow declaring MSRV directly in the Cargo.toml, pretty cool.

@jmagnuson jmagnuson merged commit 7829e6f into master Aug 19, 2020
@jmagnuson jmagnuson deleted the prep-0.1.0 branch August 19, 2020 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants