Skip to content
This repository has been archived by the owner on Jan 4, 2024. It is now read-only.

Removed unused references & added DPI scaling #12

Merged
merged 2 commits into from Aug 17, 2022
Merged

Removed unused references & added DPI scaling #12

merged 2 commits into from Aug 17, 2022

Conversation

aseemsahoo
Copy link
Contributor

  • This will solve the issue of blurred text on high DPI devices.
  • It allows the application to auto-scale to system font & DPI settings.
  • All unused references have been removed

aseemsahoo and others added 2 commits August 17, 2022 13:27
- Fixed settings for DpiAwareness
- Restored app icon
@jmalarcon
Copy link
Owner

jmalarcon commented Aug 17, 2022

Hi Aseem:

Thanks for your PR. However I've made some fixes to it (you'll see the added commit to your forked repo and to this Pull Request):

  • In the manifest, I've changed the supported Windows versions only to Windows 10+, which are the ones that the app support (Windows 11 mainly, and Windows 10 too)
  • I've used the more modern DpiAwareness setting, although it results in the same Dpi mode (System) by now, because to really adapt the UI to different DPIs I'll need to fully change the layout of the window and use Table Layout or the like, and change a lot of properties for the controls. it doesn't really fix the problem with high DPI screens. I don't see any perceptible changes. I'll open a "needs help" issue just in case someone is willing to fix this.
  • I've also changed the default AutoScale property value from Font to Dpi.
  • I've changed the name of the manifest to match the name of the project.
  • I've restored the app icon that you removed (probably by mistake)

Although I don't see any advantages with the previous changes if we don't really adapt the main screen layout to higher DPI, I've accepted the pull request because you fixed some small mispositioning of a couple of controls and made me aware of this DPI issue. Thanks.

@jmalarcon jmalarcon merged commit c01ce2b into jmalarcon:main Aug 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants