Functional tests for persistence features. #137
Conversation
Codecov Report
@@ Coverage Diff @@
## master #137 +/- ##
===========================================
+ Coverage 31.14% 50.49% +19.34%
===========================================
Files 72 74 +2
Lines 2530 2642 +112
===========================================
+ Hits 788 1334 +546
+ Misses 1718 1256 -462
- Partials 24 52 +28
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Some simple housekeeping things to fix up:
-
Naming of
Describeblocks. These should always refer to the actual struct, function or method that is being described. -
Exported functions in test suites. I wasn't sure about these - can they be unexposed?
I haven't dug into the test behaviour itself yet.
.travis.yml
Outdated
| @@ -4,7 +4,7 @@ go: '1.10' | |||
| addons: | |||
| mariadb: '10.2' | |||
| env: | |||
| - AX_MYSQL_DSN="travis@tcp(127.0.0.1:3306)/ax" | |||
| - AX_MYSQL_DSN="travis@tcp(127.0.0.1:3306)/ax" AX_BOLT_DB="test.db" | |||
There was a problem hiding this comment.
Does this still belong in this branch?
glide.yaml
Outdated
| @@ -19,3 +19,5 @@ import: | |||
| - package: golang.org/x/sync | |||
| subpackages: | |||
| - errgroup | |||
| - package: github.com/coreos/bbolt | |||
| next = next + VALUE(next)`, | ||
| n, | ||
| next = next + ?`, | ||
| n, n, |
There was a problem hiding this comment.
Could you add a comment here that this is a workaround for the MariaDB issue pls.
| . "github.com/onsi/ginkgo" | ||
| ) | ||
|
|
||
| var _ = Describe("MessageStore", func() { |
There was a problem hiding this comment.
This name should refer to the subject under test -- so just Store in this case.
| } | ||
|
|
||
| fn( | ||
| "MessageStore", |
There was a problem hiding this comment.
Same here -- Store instead of MessageStore.
| } | ||
|
|
||
| fn( | ||
| "Projection Offset Store", |
src/axmysql/saga/crud_test.go
Outdated
| . "github.com/onsi/ginkgo" | ||
| ) | ||
|
|
||
| var _ = Describe("CRUD Repository", func() { |
src/axmysql/saga/crud_test.go
Outdated
| } | ||
|
|
||
| fn( | ||
| "CRUD Repository", |
|
|
||
| // InsertOffset inserts an offset into a projection offset store. | ||
| // The value of c will be increased by the internal call of repo.IncrementOffset | ||
| func InsertOffset( |
src/axtest/sagatests/keyset.go
Outdated
| ) | ||
|
|
||
| // InsertMappingKeys inserts saga mapping keys into the repository | ||
| func InsertMappingKeys( |
|
Closing this, as discussed. All future work will be for Dogma, not Ax. |
axboltpackage removed in this PR. It basically contains only db tests inaxtestpackage.