Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Symbolic links are cloned as real files. #40

Closed
jmalloc opened this issue Apr 23, 2017 · 1 comment · Fixed by #45
Closed

Symbolic links are cloned as real files. #40

jmalloc opened this issue Apr 23, 2017 · 1 comment · Fixed by #45
Labels
bug

Comments

@jmalloc
Copy link
Owner

jmalloc commented Apr 23, 2017 •
edited
Loading

Blocked by src-d/go-git#358

The Git library used by Grit (go-git v4) is not yet considered production ready anyway, so this is not surprising. v3 might be a better fit for now.
@jmalloc jmalloc added the bug label Apr 23, 2017
@jmalloc
Copy link
Owner Author

jmalloc commented Oct 17, 2017

Looks like the upstream now supports symlinks, possibly just need a new grit build.

Can test with recoilphp/react, it contains a symlink to it's kernel's functional tests.

@jmalloc jmalloc mentioned this issue Oct 18, 2017
Merged
jmalloc added a commit that referenced this issue Oct 18, 2017
@jmalloc
Merge pull request #45 from jmalloc/update-deps
4be9186 
Updated to latest dependencies - includes go-git v4 which fixes #40.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Updated to latest dependencies. jmalloc/grit
1 participant
@jmalloc