Quotas types update #378
Merged
Quotas types update #378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "Blob" draft added a registry that all new JMAP specs need to update. This change requests that IANA add Quota into that registry.
RFC8620 isn't great about this, using "Data Types" interchangably for both definitions of sub parts of an object, and the Objects themselves that can be used as JMAP operations. I think calling these enumerations "sub types" is clearer.
This appears to just be an oversight. Fixing up the terminology
… specifies which strings are legal This aligns with things like "role" in RFC8621.
This aligns with the language used in RFC8620 for push as well
If you want to require filtering by more than one type, you can use OR or AND operators to combine filter conditions, which is clearer and more powerful than allowing a list in the condition.
chibenwa
approved these changes
Feb 2, 2023
Arsnael
reviewed
Feb 2, 2023
Co-authored-by: Rene Cordier <rene.cordier@gmail.com>
Arsnael
approved these changes
Feb 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in response to the version -11 of draft-ietf-jmap-quotas, my review as patches!