Skip to content

Commit

Permalink
use an actual music window rather than the active window. fixes crash…
Browse files Browse the repository at this point in the history
…es in xbmc#13766
  • Loading branch information
Jonathan Marshall committed Dec 18, 2012
1 parent 78ad73c commit 344e8de
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion xbmc/music/dialogs/GUIDialogSongInfo.cpp
Expand Up @@ -103,7 +103,7 @@ bool CGUIDialogSongInfo::OnMessage(CGUIMessage& message)
}
else if (iControl == CONTROL_ALBUMINFO)
{
CGUIWindowMusicBase *window = (CGUIWindowMusicBase *)g_windowManager.GetWindow(g_windowManager.GetActiveWindow());
CGUIWindowMusicBase *window = (CGUIWindowMusicBase *)g_windowManager.GetWindow(WINDOW_MUSIC_NAV);
if (window)
{
CFileItem item(*m_song);
Expand Down

4 comments on commit 344e8de

@ronie
Copy link

@ronie ronie commented on 344e8de Dec 18, 2012

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will break switching from song info to album info in WINDOW_MUSIC_PLAYLIST

@ronie
Copy link

@ronie ronie commented on 344e8de Dec 18, 2012

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and musicfiles / musicplaylisteditor

@jmarshallnz
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No it won't.

@ronie
Copy link

@ronie ronie commented on 344e8de Dec 19, 2012

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, must be the other commit then ;-)

Please sign in to comment.