Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elodie acts as if PNG files do not exist. #361

Closed
lreinink opened this issue Mar 20, 2020 · 5 comments
Closed

Elodie acts as if PNG files do not exist. #361

lreinink opened this issue Mar 20, 2020 · 5 comments

Comments

@lreinink
Copy link

lreinink commented Mar 20, 2020

I've used Elodie to organise my pictures. This included some screenshots I made on my computer, which are in PNG format. I noticed that Elodie acts as if these do not exist. They show up as 0 completed 0 error. Is this intended? What would be the best course of action?

Edit: I just read your blog post and I see that this is indeed intentional, to make sure that no unwanted images from the Downloads folder are imported. What would be the best workaround for this?

@thetom88
Copy link

May I add that also TIFF and probably DNG file are ignored?

@jmathai
Copy link
Owner

jmathai commented Mar 25, 2020

The supported file types are here.

  • DNGs - supported.
  • PNGs and TIFFs - I'm not sure if they contain EXIF but worth double checking. A simple way to check is adding it to the list I linked above.

@lreinink
Copy link
Author

jmathai, thank you. This worked for me. the PNG files do contain exif, but all locations are unknown. This is to be expected, however.

@jmathai
Copy link
Owner

jmathai commented Mar 25, 2020

@lreinink 👍. if you made any changes locally that worked for you then let me know and if it's useful for others it would be great if you could submit a pull request.

@lreinink
Copy link
Author

lreinink commented Mar 25, 2020

I did exactly what you proposed, I changed extensions = ('arw', 'cr2', 'dng', 'gif', 'heic', 'jpeg', 'jpg', 'nef', 'rw2') in photo.py to extensions = ('arw', 'cr2', 'dng', 'gif', 'heic', 'jpeg', 'jpg', 'nef', 'rw2', 'png') and reran elodie on the missed files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants