Fix --update-with-info-json message

[alxjsn]

Didn't realize why the configuration option wasn't working at first, then I realized the warning printed the wrong option.

[jmbannon]

Thanks for this @alxjsn. As a heads up, I think I will be changing how this feature works in the near future

[codecov]

Codecov Report

Merging #618 (c504591) into master (2f1756d) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #618   +/-   ##
=======================================
  Coverage   96.71%   96.72%           
=======================================
  Files          69       69           
  Lines        4658     4670   +12     
=======================================
+ Hits         4505     4517   +12     
  Misses        153      153           

Impacted Files	Coverage Δ
src/ytdl_sub/cli/main.py	96.68% <ø> (ø)

... and 1 file with indirect coverage changes

[jmbannon]

when you get a sec @alxjsn could you run make lint and re-push

[alxjsn]

Any idea why I'm getting more errors than the CI build?

[alxjsn@okonomiyaki ytdl-sub]$ make lint
Skipped 2 files
All done! ✨ 🍰 ✨
147 files left unchanged.
************* Module ytdl_sub.cli.main
src/ytdl_sub/cli/main.py:320:0: C0301: Line too long (104/100) (line-too-long)
src/ytdl_sub/cli/main.py:61:4: E1101: Module 'os' has no 'makedirs' member (no-member)
src/ytdl_sub/cli/main.py:61:16: E1101: Module 'os' has no 'path' member (no-member)
************* Module ytdl_sub.config.config_file
src/ytdl_sub/config/config_file.py:33:12: E1101: Module 'os' has no 'umask' member (no-member)
************* Module ytdl_sub.config.defaults
src/ytdl_sub/config/defaults.py:16:26: E1101: Module 'os' has no 'pathconf' member (no-member)
************* Module ytdl_sub.config.preset_options
src/ytdl_sub/config/preset_options.py:1:0: E0611: No name 'ABC' in module 'abc' (no-name-in-module)
************* Module ytdl_sub.downloaders.base_downloader
src/ytdl_sub/downloaders/base_downloader.py:2:0: E0611: No name 'ABC' in module 'abc' (no-name-in-module)
src/ytdl_sub/downloaders/base_downloader.py:58:5: E1101: Module 'abc' has no 'abstractmethod' member (no-member)
src/ytdl_sub/downloaders/base_downloader.py:62:5: E1101: Module 'abc' has no 'abstractmethod' member (no-member)
************* Module ytdl_sub.downloaders.ytdlp
src/ytdl_sub/downloaders/ytdlp.py:146:29: E1101: Module 'os' has no 'listdir' member (no-member)
************* Module ytdl_sub.downloaders.url.downloader
src/ytdl_sub/downloaders/url/downloader.py:4:0: E0611: No name 'ABC' in module 'abc' (no-name-in-module)
src/ytdl_sub/downloaders/url/downloader.py:56:5: E1101: Module 'abc' has no 'abstractmethod' member (no-member)
src/ytdl_sub/downloaders/url/downloader.py:127:38: E1101: Module 'os' has no 'path' member (no-member)
src/ytdl_sub/downloaders/url/downloader.py:372:51: E1101: Module 'os' has no 'path' member (no-member)
src/ytdl_sub/downloaders/url/downloader.py:376:15: E1101: Module 'os' has no 'path' member (no-member)
src/ytdl_sub/downloaders/url/downloader.py:385:39: E1101: Module 'os' has no 'path' member (no-member)
src/ytdl_sub/downloaders/url/downloader.py:395:28: E1101: Module 'os' has no 'listdir' member (no-member)
************* Module ytdl_sub.entries.base_entry
src/ytdl_sub/entries/base_entry.py:1:0: E0611: No name 'ABC' in module 'abc' (no-name-in-module)
************* Module ytdl_sub.entries.entry
src/ytdl_sub/entries/entry.py:28:15: E1101: Module 'os' has no 'path' member (no-member)
src/ytdl_sub/entries/entry.py:70:15: E1101: Module 'os' has no 'path' member (no-member)
src/ytdl_sub/entries/entry.py:102:22: E1101: Module 'os' has no 'path' member (no-member)
src/ytdl_sub/entries/entry.py:108:19: E1101: Module 'os' has no 'path' member (no-member)
************* Module ytdl_sub.plugins.audio_extract
src/ytdl_sub/plugins/audio_extract.py:1:0: E0611: No name 'path' in module 'os' (no-name-in-module)
src/ytdl_sub/plugins/audio_extract.py:111:19: E1101: Module 'os' has no 'path' member (no-member)
************* Module ytdl_sub.plugins.file_convert
src/ytdl_sub/plugins/file_convert.py:174:19: E1101: Module 'os' has no 'path' member (no-member)
src/ytdl_sub/plugins/file_convert.py:190:23: E1101: Module 'os' has no 'path' member (no-member)
************* Module ytdl_sub.plugins.nfo_tags
src/ytdl_sub/plugins/nfo_tags.py:2:0: E0611: No name 'ABC' in module 'abc' (no-name-in-module)
src/ytdl_sub/plugins/nfo_tags.py:152:8: E1101: Module 'os' has no 'makedirs' member (no-member)
src/ytdl_sub/plugins/nfo_tags.py:152:20: E1101: Module 'os' has no 'path' member (no-member)
************* Module ytdl_sub.plugins.plugin
src/ytdl_sub/plugins/plugin.py:1:0: E0611: No name 'ABC' in module 'abc' (no-name-in-module)
************* Module ytdl_sub.plugins.split_by_chapters
src/ytdl_sub/plugins/split_by_chapters.py:2:0: E0611: No name 'path' in module 'os' (no-name-in-module)
src/ytdl_sub/plugins/split_by_chapters.py:213:19: E1101: Module 'os' has no 'path' member (no-member)
************* Module ytdl_sub.subscriptions.base_subscription
src/ytdl_sub/subscriptions/base_subscription.py:1:0: E0611: No name 'ABC' in module 'abc' (no-name-in-module)
************* Module ytdl_sub.subscriptions.subscription_download
src/ytdl_sub/subscriptions/subscription_download.py:4:0: E0611: No name 'ABC' in module 'abc' (no-name-in-module)
src/ytdl_sub/subscriptions/subscription_download.py:105:11: E1101: Module 'os' has no 'path' member (no-member)
src/ytdl_sub/subscriptions/subscription_download.py:115:8: E1101: Module 'os' has no 'makedirs' member (no-member)
src/ytdl_sub/subscriptions/subscription_download.py:156:42: E1101: Module 'os' has no 'walk' member (no-member)
src/ytdl_sub/subscriptions/subscription_download.py:159:31: E1101: Module 'os' has no 'listdir' member (no-member)
src/ytdl_sub/subscriptions/subscription_download.py:160:28: E1101: Module 'os' has no 'rmdir' member (no-member)
************* Module ytdl_sub.thread.log_entries_downloaded_listener
src/ytdl_sub/thread/log_entries_downloaded_listener.py:2:0: E0611: No name 'path' in module 'os' (no-name-in-module)
src/ytdl_sub/thread/log_entries_downloaded_listener.py:50:21: E1101: Module 'os' has no 'path' member (no-member)
************* Module ytdl_sub.utils.file_handler
src/ytdl_sub/utils/file_handler.py:62:12: E1101: Module 'os' has no 'path' member (no-member)
src/ytdl_sub/utils/file_handler.py:62:49: E1101: Module 'os' has no 'path' member (no-member)
src/ytdl_sub/utils/file_handler.py:64:7: E1101: Module 'os' has no 'path' member (no-member)
src/ytdl_sub/utils/file_handler.py:64:44: E1101: Module 'os' has no 'path' member (no-member)
src/ytdl_sub/utils/file_handler.py:186:37: E1101: Module 'os' has no 'sep' member (no-member)
src/ytdl_sub/utils/file_handler.py:271:29: E1101: Module 'os' has no 'path' member (no-member)
src/ytdl_sub/utils/file_handler.py:272:24: E1101: Module 'os' has no 'path' member (no-member)
src/ytdl_sub/utils/file_handler.py:415:11: E1101: Module 'os' has no 'path' member (no-member)
src/ytdl_sub/utils/file_handler.py:416:12: E1101: Module 'os' has no 'remove' member (no-member)
src/ytdl_sub/utils/file_handler.py:452:12: E1101: Module 'os' has no 'path' member (no-member)
src/ytdl_sub/utils/file_handler.py:467:12: E1101: Module 'os' has no 'makedirs' member (no-member)
src/ytdl_sub/utils/file_handler.py:467:24: E1101: Module 'os' has no 'path' member (no-member)
src/ytdl_sub/utils/file_handler.py:489:17: E1101: Module 'os' has no 'path' member (no-member)
************* Module ytdl_sub.utils.file_lock
src/ytdl_sub/utils/file_lock.py:40:38: E1101: Module 'os' has no 'getcwd' member (no-member)
src/ytdl_sub/utils/file_lock.py:42:17: E1101: Module 'os' has no 'getcwd' member (no-member)
************* Module ytdl_sub.utils.logger
src/ytdl_sub/utils/logger.py:72:21: E1101: Module 'io' has no 'StringIO' member (no-member)
************* Module ytdl_sub.utils.thumbnail
src/ytdl_sub/utils/thumbnail.py:36:7: E1101: Module 'os' has no 'path' member (no-member)
src/ytdl_sub/utils/thumbnail.py:78:12: E1101: Module 'os' has no 'makedirs' member (no-member)
src/ytdl_sub/utils/thumbnail.py:78:24: E1101: Module 'os' has no 'path' member (no-member)
************* Module ytdl_sub.utils.yaml
src/ytdl_sub/utils/yaml.py:1:0: E0611: No name 'path' in module 'os' (no-name-in-module)
src/ytdl_sub/utils/yaml.py:2:0: E0611: No name 'StringIO' in module 'io' (no-name-in-module)
src/ytdl_sub/utils/yaml.py:34:11: E1101: Module 'os' has no 'path' member (no-member)
************* Module ytdl_sub.validators.file_path_validators
src/ytdl_sub/validators/file_path_validators.py:21:15: E1101: Module 'os' has no 'path' member (no-member)
src/ytdl_sub/validators/file_path_validators.py:79:36: E1101: Module 'os' has no 'path' member (no-member)
src/ytdl_sub/validators/file_path_validators.py:147:15: E1101: Module 'os' has no 'path' member (no-member)
************* Module ytdl_sub.validators.nfo_validators
src/ytdl_sub/validators/nfo_validators.py:1:0: E0611: No name 'ABC' in module 'abc' (no-name-in-module)
************* Module ytdl_sub.validators.validators
src/ytdl_sub/validators/validators.py:2:0: E0611: No name 'ABC' in module 'abc' (no-name-in-module)
************* Module ytdl_sub.ytdl_additions.enhanced_download_archive
src/ytdl_sub/ytdl_additions/enhanced_download_archive.py:3:0: E0611: No name 'path' in module 'os' (no-name-in-module)
src/ytdl_sub/ytdl_additions/enhanced_download_archive.py:106:15: E1101: Module 'os' has no 'path' member (no-member)
src/ytdl_sub/ytdl_additions/enhanced_download_archive.py:367:11: E1101: Module 'os' has no 'path' member (no-member)

------------------------------------------------------------------
Your code has been rated at 9.19/10 (previous run: 9.19/10, +0.00)

make: [Makefile:19: lint] Error 18 (ignored)

[jmbannon]

@alxjsn old python version maybe? Needs >=3.10

[jmbannon]

@alxjsn and pip install -e .[lint]

[alxjsn]

I'm on Python 3.11.3 and installed those packages as well. I'll try to troubleshoot some more when I get some time.

[jmbannon]

I'm on Python 3.11.3 and installed those packages as well. I'll try to troubleshoot some more when I get some time.

Maybe some of the lint packages aren't 3.11 compatible yet

[alxjsn]

Works with 3.10, but looks like black doesn't address C0301 so I ran black --preview and only committed that one file.

Black issue: psf/black#1802