Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Music Videos with Extras presets #808

Merged
merged 30 commits into from
Jun 6, 2024
Merged

[FEATURE] Music Videos with Extras presets #808

merged 30 commits into from
Jun 6, 2024

Conversation

jmbannon
Copy link
Owner

@jmbannon jmbannon commented Nov 6, 2023

Enhances the music video presets by supporting the following syntax:

subscriptions.yaml

__preset__:
  overrides:
    music_video_directory: "/music_videos"

# Choose between Jellyfin/Kodi/Plex Music Videos preset:
#   - Plex Music Videos:
#   - Jellyfin Music Videos:
#   - Kodi Music Videos:
#
"Plex Music Videos":

  = Pop:  # Sets genre tag to "Pop"
    "Rick Astley": "https://www.youtube.com/playlist?list=PLlaN88a7y2_plecYoJxvRFTLHVbIVAOoc"
    "Michael Jackson": "https://www.youtube.com/playlist?list=OLAK5uy_mnY03zP6abNWH929q2XhGzWD_2uKJ_n8E"

  = Rock:
    # Prefixing with '+' puts the subscription into 'map-mode'.
    # Music video presets in map-mode support grouping videos into different
    # categories, which get set on the album field.
    #
    # URLs can either be strings, or maps that can overload title, year, date
    "+ Guns N' Roses":
      Music Videos:
        - "https://www.youtube.com/playlist?list=PLOTK54q5K4INNXaHKtmXYr6J7CajWjqeJ"
      Concerts:
        - title: "Live at The Ritz - New York City"
          year: "1988"
          url: "https://www.youtube.com/watch?v=OldpIhHPsbs"
        - title: "Live at The Hollywood Bowl"
          date: "2023-01-11"
          url: "https://www.youtube.com/watch?v=Z7hutGlvq9I"

The 'map-mode' (denoted by +) lets you specify a map of music video categories. Under each category, a URL can be specified as-is or with additional metadata (title, year/date, url).

Music videos and concerts, especially older ones, are typically uploaded by random users with inconsistencies in their titles. This syntax aims to make it easy to specify individual URLs with the ability to overwrite their title and year, and group them by category.

Copy link

codecov bot commented Nov 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.04%. Comparing base (64d3082) to head (d14506d).
Report is 10 commits behind head on master.

Current head d14506d differs from pull request most recent head 59cfe3f

Please upload reports for the commit 59cfe3f to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #808      +/-   ##
==========================================
+ Coverage   96.77%   97.04%   +0.26%     
==========================================
  Files         115      115              
  Lines        7381     7167     -214     
==========================================
- Hits         7143     6955     -188     
+ Misses        238      212      -26     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jmbannon
Copy link
Owner Author

jmbannon commented Jun 2, 2024

Instead should have:

Plini:
  Concerts:
    - https://...
  Music Videos:
    - https://...
  Interviews:
    - https://
    - title: "Custom Title"
      url: "https://...

@jmbannon
Copy link
Owner Author

jmbannon commented Jun 6, 2024

FYI @android-808 , finally getting around to pushing this 🙂

@jmbannon jmbannon merged commit 5e94729 into master Jun 6, 2024
33 of 34 checks passed
@jmbannon jmbannon deleted the j/music-extras branch June 6, 2024 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant