Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

consider .packageName in new_condition() #12

Closed
jmbarbone opened this issue Nov 25, 2022 · 0 comments · Fixed by #13
Closed

consider .packageName in new_condition() #12

jmbarbone opened this issue Nov 25, 2022 · 0 comments · Fixed by #13
Assignees
@jmbarbone
Labels
enhancement New feature or request
Milestone
0.1.2

Comments

@jmbarbone
Copy link
Owner

the class value can utilize the .packageName variable within a package to appropriately append to the class.

conditionMessage(new_condition("hello", class = "foo"))
#> [1] "<fooError> hello"

could instead be ...

conditionMessage(new_condition("hello", class = "foo"))
#> [1] "<fuj:fooError> hello"

... to track the origin of the package
@jmbarbone jmbarbone added the enhancement New feature or request label Nov 25, 2022
@jmbarbone jmbarbone self-assigned this Nov 25, 2022
jmbarbone added a commit that referenced this issue Nov 25, 2022
@jmbarbone
[#12] adds pkg parameter to new_condition()
b3cedf2
jmbarbone added a commit that referenced this issue Nov 25, 2022
@jmbarbone
[#12] redoc
54a7729
jmbarbone added a commit that referenced this issue Nov 25, 2022
@jmbarbone
[#12] updates condition tests
778c3bb
jmbarbone added a commit that referenced this issue Nov 25, 2022
@jmbarbone
[#12] bump version
2639d01
jmbarbone added a commit that referenced this issue Nov 25, 2022
@jmbarbone
[#12] update NEWS
878248d
jmbarbone added a commit that referenced this issue Nov 25, 2022
@jmbarbone
[#12] update word list
b8622eb
@jmbarbone jmbarbone mentioned this issue Nov 25, 2022
Merged
jmbarbone added a commit that referenced this issue Dec 15, 2022
@jmbarbone
[#12] try better to get package name
cdf3bf2
jmbarbone added a commit that referenced this issue Dec 16, 2022
@jmbarbone
[#12] Merge branch 'main' into 12-package-name
036dd13
@jmbarbone jmbarbone added this to the 0.1.2 milestone Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jmbarbone jmbarbone

Labels
enhancement New feature or request
Projects
None yet
Milestone
0.1.2
Development

Successfully merging a pull request may close this issue.

12 package name jmbarbone/fuj
1 participant
@jmbarbone