Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add compression options for write_file_md5() #224

Closed
jmbarbone opened this issue Nov 29, 2023 · 0 comments · Fixed by #225
Closed

add compression options for write_file_md5() #224

jmbarbone opened this issue Nov 29, 2023 · 0 comments · Fixed by #225
Assignees
Labels
enhancement 💎 Feature enhancement
Milestone

Comments

@jmbarbone
Copy link
Owner

can take some inspiration from readr::write_rds():

compress <- match.arg(compress, c("none", "gz", "bz", "xz"))
con <- switch(
  compress,
  none = file(file, ...),
  gz = gzfile(file, ...),
  bz = bzfile(file, ...),
  xz = xzfile(file, ...)
)

write_function(x, con, ...)

all functions need to be rewritten to accept connections and set encoding via that function instead.

@jmbarbone jmbarbone added the enhancement 💎 Feature enhancement label Nov 29, 2023
@jmbarbone jmbarbone added this to the 0.8.0 milestone Nov 29, 2023
@jmbarbone jmbarbone self-assigned this Nov 29, 2023
jmbarbone added a commit that referenced this issue Dec 4, 2023
jmbarbone added a commit that referenced this issue Dec 4, 2023
jmbarbone added a commit that referenced this issue Dec 4, 2023
jmbarbone added a commit that referenced this issue Dec 4, 2023
jmbarbone added a commit that referenced this issue Dec 4, 2023
@jmbarbone jmbarbone mentioned this issue Dec 4, 2023
jmbarbone added a commit that referenced this issue Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 💎 Feature enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant