Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

detail() shouldn't append fact to factors #50

Closed
jmbarbone opened this issue Oct 26, 2021 · 0 comments · Fixed by #51
Closed

detail() shouldn't append fact to factors #50

jmbarbone opened this issue Oct 26, 2021 · 0 comments · Fixed by #51
Labels
bug 🐛 Something isn't working

Comments

@jmbarbone
Copy link
Owner

library(mark)

detail(factor("a"))
#>          class    type label n na min_c max_c level level_n note comment
#> 1 fact; factor integer  <NA> 1  0     1     1     a       1 <NA>    <NA>
detail(ordered("a"))
#>                   class    type label n na min_c max_c level level_n note
#> 1 fact; ordered; factor integer  <NA> 1  0     1     1     a       1 <NA>
#>   comment
#> 1    <NA>

Created on 2021-10-26 by the reprex package (v2.0.1)

@jmbarbone jmbarbone added the bug 🐛 Something isn't working label Oct 26, 2021
jmbarbone added a commit that referenced this issue Oct 26, 2021
jmbarbone added a commit that referenced this issue Oct 26, 2021
* rewsolves #50

* changes argument order

* corrects use of factor_n

* syntax typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant