Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get_language_lines_in_visual_selection off by one #70

Closed
benlubas opened this issue Oct 31, 2023 · 1 comment · Fixed by #114
Closed

get_language_lines_in_visual_selection off by one #70

benlubas opened this issue Oct 31, 2023 · 1 comment · Fixed by #114

Comments

@benlubas
Copy link
Contributor

if I have a code block like this:

```{python}
print("Hello")
x = 10
...

and call otterkeeper.get_language_lines_in_visual_selection(true) with the first line visually selected (visual or visual line mode) I get nil.

So I think there is an off by one somewhere

@jmbuhr
Copy link
Owner

jmbuhr commented Nov 1, 2023

That is quite likely, I have gone through several iterations where I thought I'd fixed an off by one error only to get a different one. Like putting in an usb-stick, but worse. I'll have a look!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants