[Bug 822630] [contacts] Possible CSP problems

jmcanterafonseca · Dec 20, 2012 · fea6fb7 · fea6fb7
1 parent 5d27a85
commit fea6fb7
Show file tree

Hide file tree

Showing 5 changed files with 12 additions and 10 deletions.
diff --git a/apps/communications/contacts/index.html b/apps/communications/contacts/index.html
@@ -241,7 +241,7 @@ <h2 data-l10n-id="social-network" id="social-label">Social Network</h2>
                 <h2>#type#</h2>
                 <div class="item">
                   <div class="item-body-exp">
-                    <a href="javascript: void(0);" class="action action-block">
+                    <a href="#" class="action action-block">
                       <span role="button" class="icon-address" data-l10n-id="legendAddress">Address</span>
                       <b>
                       <span>#streetAddress#</span>

diff --git a/apps/communications/contacts/oauth2/dialogs_end.html b/apps/communications/contacts/oauth2/dialogs_end.html
@@ -13,13 +13,10 @@
 <html>
   <head>
     <meta charset="UTF-8">
-    <script src="oauth2/js/parameters.js"></script>
+    <script src="js/parameters.js"></script>
+    <script src="js/dialogs_end_init.js"></script>
   </head>
 
   <body>
-    <script>
-      window.opener.postMessage('closed',
-                                fb.oauthflow.params['contactsAppOrigin']);
-      window.close();
-    </script>
+  </body>
 </html>
diff --git a/apps/communications/contacts/oauth2/flow.html b/apps/communications/contacts/oauth2/flow.html
@@ -16,8 +16,6 @@
   <body>
     <script src="js/flow.js"></script>
     <script src="js/parameters.js"></script>
-    <script>
-      fb.oauthflow.init();
-    </script>
+    <script src="js/flow_init.js"></script>
   </body>
 </html>
diff --git a/apps/communications/contacts/oauth2/js/dialogs_end_init.js b/apps/communications/contacts/oauth2/js/dialogs_end_init.js
@@ -0,0 +1,4 @@
+'use strict';
+
+window.opener.postMessage('closed', fb.oauthflow.params['contactsAppOrigin']);
+window.close();
diff --git a/apps/communications/contacts/oauth2/js/flow_init.js b/apps/communications/contacts/oauth2/js/flow_init.js
@@ -0,0 +1,3 @@
+'use strict';
+
+fb.oauthflow.init();