Support apispec >= 4 #206
Merged
Support apispec >= 4 #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Rename 'default_in' (marshmallow-code/apispec#526) 2. Dict schema: convert it to object and handle special case 'body', since prior used method no longer exists (marshmallow-code/apispec#581)
Supporting different apispec version requires different logic for each of them. New apispec requires Python >= 3.6
Codecov Report
@@ Coverage Diff @@
## master #206 +/- ##
==========================================
+ Coverage 97.26% 97.86% +0.59%
==========================================
Files 8 8
Lines 366 374 +8
==========================================
+ Hits 356 366 +10
+ Misses 10 8 -2
Continue to review full report at Codecov.
|
Closed
|
Apologies for the delay. I'll try to look at this soon |
apispec no longer supports 3.5
|
This is released in 0.11.0. Thanks for the PR! |
|
Thank you for the help! |
jollysahil
pushed a commit
to levrofin/flask-apispec
that referenced
this pull request
Sep 12, 2023
* Compatibility with apispec 4 1. Rename 'default_in' (marshmallow-code/apispec#526) 2. Dict schema: convert it to object and handle special case 'body', since prior used method no longer exists (marshmallow-code/apispec#581) * Drop support for apispec < 4, Python < 3.6 Supporting different apispec version requires different logic for each of them. New apispec requires Python >= 3.6 * Remove unused imports * Update tox.ini * Update changelog * Drop Python 3.5 support apispec no longer supports 3.5 Co-authored-by: Steven Loria <sloria1@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduce support for compatibility-breaking apispec 4.0.0. Since some interface and argument names are changed, I decided to drop support for older apispec. Switching to apispec 4 may require some changes in code (see https://github.com/marshmallow-code/apispec/blob/dev/CHANGELOG.rst).
Behavior of
fields2parametersis now handled directly by flask-apispec: old method no longer exists and new 'official' way, converting toSchema, when fields should be inbodyconflicts with flask-apispec behavior (it generates reference to named schema instead of putting just dict with definition and registers new schema every time converted, so output can contain multiple schemas; in addition, there is a problem with names for multiple auto-generated schemas).I strongly recommend making a recovery release with apispec pined to < 4 (PR #204) for those, who would keep on it, before merging my changes.
Fix #202