New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix button in form issue #56

Open
wants to merge 4 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@M157q
Copy link

M157q commented Nov 18, 2015

Support <button> tags in <form> .

M157q added some commits Nov 18, 2015

Add button into form tags.
<button> can be added into <form>.
Add this new feature so robobrowser can deal with <button> tags in
<form>
@gled-rs

This comment has been minimized.

Copy link

gled-rs commented Feb 29, 2016

+1 on this PR

If Button tag has no type, assume the type of it is 'submit'.
According to <https://developer.mozilla.org/nl/docs/Web/HTML/Element/button>:

+ The type of the button. Possible values are:
    + submit: The button submits the form data to the server.
        + This is the default if the attribute is not specified, or if the attribute is dynamically changed to an empty or invalid value.
    + reset: The button resets all the controls to their initial values.
    + button: The button has no default behavior. It can have client-side scripts associated with the element's events, which are triggered when the events occur.
    + menu: The button opens a popup menu defined via its designated <menu> element.

So, we can treat the button tag with no type specifed as a submit tag.

Thanks Vincent Wagelaar <vincent@iterator.nl> emailing me about this patch.

@M157q M157q force-pushed the M157q:fix_button_in_form_issue branch from eadc471 to 9df767b Nov 6, 2016

@M157q

This comment has been minimized.

Copy link
Author

M157q commented Nov 6, 2016

Set version of flake8 to 2.6.2 to pass the CI test for python 2.6.
flake8 no longer supports Python 2.6 since flake8-3.0.0.
@JoabMendes

This comment has been minimized.

Copy link

JoabMendes commented Nov 10, 2016

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment