Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISSUE-151 - Add Emoji output to readme #1

Conversation

jmcconnell26
Copy link
Owner

No description provided.

@anderejd
Copy link

anderejd commented Dec 17, 2020

@jmcconnell26 Interesting bug, I can't see anything that's obviously wrong. Try adding some extra logging for each output fragment?

The unwanted terminal control sequence in the README is probably created by this line:

line.push_str(format!("\x1B[{}C", shift_chars).as_str()); // Move the cursor to the right so that it points to the icon character.

This source file seems to need some customisation to support non-terminal output.

Signed-off-by: joshmc <josh-mcc@tiscali.co.uk>
@jmcconnell26 jmcconnell26 force-pushed the ISSUE-151-AddGitHubMDFormatting-AddEmojiToReadme branch from a56e67e to 0514611 Compare December 18, 2020 19:39
@jmcconnell26
Copy link
Owner Author

@jmcconnell26 Interesting bug, I can't see anything that's obviously wrong. Try adding some extra logging for each output fragment?

The unwanted terminal control sequence in the README is probably created by this line:

line.push_str(format!("\x1B[{}C", shift_chars).as_str()); // Move the cursor to the right so that it points to the icon character.

This source file seems to need some customisation to support non-terminal output.

Ahh, that looks to be it indeed! That looks much better now. If you're happy with it I'll merge this into this PR here geiger-rs#164?

@anderejd
Copy link

anderejd commented Dec 18, 2020

@jmcconnell26 Great, that looks good to me!

@jmcconnell26 jmcconnell26 merged commit 92fe2dd into ISSUE-151-AddGitHubMDFormatting Dec 18, 2020
@jmcconnell26 jmcconnell26 deleted the ISSUE-151-AddGitHubMDFormatting-AddEmojiToReadme branch December 18, 2020 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants