Windows compatibility #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
githubDante
commented
May 15, 2023
githubDante
commented
- Added platform check
- Use selector according to the platform (only select is available on Windows select.poll() is not supported on windows #37)
- Platform compatible tests
- Tested on Windows and Linux
* Switched from _select_ to the _selectors_ module for compatibility * Added platform check
Apparently reuse_port is not available either
On Windows the event generated from socket.close somtimes is propagated before the event.set() operation which in turn causes the reader thread to attempt reading from a closed socket. Fixes: OSError: [WinError 10038] An operation was attempted on something that is not a socket
|
Thanks for this. Merged. Closes #37 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.