feat: support users and logins #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitest has better general support, uvu seems to be unmaintained, and vitest support using a separate file for e2e describe suites, meaning I can have better code separation for how these tests should be written and maintained, win-win.
While these technically do relate to logging, the logging module is related to _all_ applications rather than just the http side so this allows for the cli app(s) to startup without issue
Implementation to follow
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 8170c68. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch
✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's honestly a lot of features in this PR. A
ZodValidationPipe, aServerHashModuleand service, abase32library that holds the valid values for a base32 string and a regex for a ulid (should be renamed), e2e tests has been updated so that migrations run for the test database before the tests are ran, the e2e tests are now ran through vitest (uvu should be fully removed soon), the binding of interceptors and filters has been moved to theRootModuleto better manage when they get used, and finally, user signup and login is now functional as well.I should still verify that the cookies are sent back properly with the necessary information, if any, but the session that should be created is indeed updated in the Redis database after signup, so it should all be functional as is