Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use register_buffer instead of creating parameter with no grad for b #7

Merged
merged 1 commit into from
Oct 22, 2022

Conversation

jmclong
Copy link
Owner

@jmclong jmclong commented Oct 22, 2022

Fixes #6

@jmclong jmclong merged commit fa5183e into main Oct 22, 2022
@jmclong jmclong deleted the fix-state-dict branch October 22, 2022 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Question: Why are you using nn.parameter.Parameter with requires_grad=False instead of register_buffer?
1 participant