Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Custom properties #355

Closed
cez81 opened this issue May 27, 2016 · 7 comments
Closed

Feature request: Custom properties #355

cez81 opened this issue May 27, 2016 · 7 comments
Assignees
Labels
feature request long term May eventually be added.

Comments

@cez81
Copy link

cez81 commented May 27, 2016

Currently XlsxWriter only support set the core properties. I would like support added for setting custom properties stored in docsProps/custom.xml. Custom properties are similar to core properties such as create time but store other bits of information. Custom properties can be found from menu Info - Properties - Advanced Properties in Excel.
My use case for this is to add some company specific information eg. signum, department, access class etc.
More information about custom properties can be found in ISO-IEC-29500-1 section 22.3.

@jmcnamara
Copy link
Owner

jmcnamara commented May 27, 2016

If this is a feature request could you please describe the feature that you are requesting.

@cez81
Copy link
Author

cez81 commented May 27, 2016

I have updated the request with some more information. I'm already working on this and almost done (I think). Got a failing test case comparing against real Excel file left to solve.

@jmcnamara
Copy link
Owner

Hi,

I understand what custom properties are and I am familiar with the spec.

However, feature requests need to have some +1s to indicate that they are a feature that users want added in preference to other requested features and this,currently, isn't something that anyone else had requested.

In general the code is the easy part so that doesn't sway the argument.

I'll leave this open and if I get other •1s I'll add the feature.

John

@jmcnamara jmcnamara added feature request long term May eventually be added. labels May 27, 2016
@jmcnamara jmcnamara self-assigned this May 27, 2016
@tooh
Copy link

tooh commented May 28, 2016

+1

jmcnamara added a commit that referenced this issue May 29, 2016
Added workbook method to set custom document properties.
Feature request #355.
@jmcnamara
Copy link
Owner

Hi,

I've added a workbook method called set_custom_property() and pushed a version to master. The documentation is here: set_custom_property()

Try it out and let me know how you get on.

John

@cez81
Copy link
Author

cez81 commented May 30, 2016

Hi,
That's great, thank you for the quick solution! I have tested it and works as expected.

Br, Jonas

@jmcnamara
Copy link
Owner

Thanks for testing and for the prompt to add it.

This is now available in XlsxWriter 0.88: https://xlsxwriter.readthedocs.io/changes.html

John

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request long term May eventually be added.
Projects
None yet
Development

No branches or pull requests

3 participants