Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CMake: doesn't enforce a unicode build for MSVC #153

Closed
RalfKubis opened this issue Mar 14, 2018 · 2 comments
Closed

CMake: doesn't enforce a unicode build for MSVC #153

RalfKubis opened this issue Mar 14, 2018 · 2 comments
Assignees
@jmcnamara
Labels
bug cmake short term

Comments

@RalfKubis
Copy link

RalfKubis commented Mar 14, 2018 •
edited by jmcnamara
Loading

Apparently the library requires to be build with the symbol _UNICODE being defined.
Otherwise one gets defects like described in #104 and #148 or similar.

A potential fix would be to define this symbol in CMakeLists.txt.
@jmcnamara jmcnamara self-assigned this Mar 14, 2018
@jmcnamara
Copy link
Owner

I made an attempt to try implement this via commandline switches to cmake. Unsuccessfully.

@Alexhuszagh Could you have a look at implementing this. It is catching a lot of Windows users using cmake.

@RalfKubis
Copy link
Author

I'm on it. Just preparing a pull-request.

@jmcnamara jmcnamara mentioned this issue Mar 14, 2018
Closed
Alexhuszagh pushed a commit to Alexhuszagh/libxlsxwriter that referenced this issue Apr 19, 2018
PR for issue jmcnamara#153, ensure the use of wide paths works withou…
01ef9ab 
…t _UNICODE defined.
@Alexhuszagh Alexhuszagh mentioned this issue Apr 19, 2018
Merged
jmcnamara pushed a commit that referenced this issue Apr 23, 2018
@jmcnamara
PR for issue #153, ensure the use of wide paths works without _UNICOD…
6cb7ef1 
…E defined.
jmcnamara added a commit that referenced this issue Apr 23, 2018
@jmcnamara
Revert "PR for issue #153, ensure the use of wide paths works without…
a69a369 
… _UNICODE defined."

This reverts commit 6cb7ef1.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jmcnamara jmcnamara

Labels
bug cmake short term
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jmcnamara @RalfKubis