Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quote pdb paths #244

Merged
merged 1 commit into from
Aug 30, 2019
Merged

quote pdb paths #244

merged 1 commit into from
Aug 30, 2019

Conversation

John-Colvin
Copy link
Contributor

otherwise you can't build if CMAKE_BINARY_DIR has spaces in

@jmcnamara
Copy link
Owner

Thanks.

There is another unquoted instance of CMAKE_BINARY_DIR CMakeLists.txt#L320. Does that need to change as well? If so can you redo and rebase the change.

@John-Colvin
Copy link
Contributor Author

John-Colvin commented Aug 30, 2019

I don't believe that one needs quoting as it's being used on its own as opposed to being built in to a string. I haven't had any problems with it so far.

@jmcnamara
Copy link
Owner

Thanks. Merged as is then.

@jmcnamara jmcnamara merged commit 07fa7c5 into jmcnamara:master Aug 30, 2019
@John-Colvin John-Colvin deleted the patch-1 branch November 19, 2019 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants