Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.16 #7

Closed
wants to merge 8 commits into from
Closed

0.16 #7

wants to merge 8 commits into from

Conversation

jewilke
Copy link

@jewilke jewilke commented Jan 26, 2014

Hi John,

this is my work for the next release.
There is still a typo in the Changes file: Addes Dokuwiki
Well, that's not the most recently pushed Version...

Rgds, Jens

@ghost ghost assigned jmcnamara Jan 27, 2014
@jmcnamara
Copy link
Owner

Hi Jens,

Thanks for this.

There is a little bit too much unrelated changes in this PR. So it it would be be best to split these out into different branches/Pull Requests.

I'll make some comments in-line.

John

@jewilke
Copy link
Author

jewilke commented Jan 27, 2014

Typo is fixed...

@@ -1,5 +1,15 @@
Revision history for Pod::Simple::Wiki.

0.16 Jan 26 2014
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll handle changes like version numbers and release notes prior to release.

@jmcnamara
Copy link
Owner

Hi Jens,

Overall that looks good but as I said above there is too much change here to review/merge in one go.

Create a separate branch and Pull Request (PR) for each group of functional changes. Try to limit the commits on each branch to 1. If you are familiar with git then squash the commits into one (on each branch) and submit them in the PR.

Call the branches feature_wikitype_description or fix_wikitype_description like feature_twiki_links.

Thanks,

John

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants