Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I changed some fields' types of the
CellType
enum fromString
toBox<str>
orRc<str>
. Result:This improves cache locality and allows the compiler to better optimize its use.
I also refactored the
prepare_formula
function because I needed it to output aBox<str>
instead of aString
.Why
Rc<str>
?To improve the performance of the
shared_string_index
function. This is a hot function that needs to clone strings some of the time. By usingRc<str>
the clones become really cheap.