Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make EMA parameters configurable #244

Closed
jmcollin78 opened this issue Dec 1, 2023 · 1 comment
Closed

Make EMA parameters configurable #244

jmcollin78 opened this issue Dec 1, 2023 · 1 comment
Labels
developed When development is done and tested enhancement New feature or request P1 Priority 1

Comments

@jmcollin78
Copy link
Owner

Auto window open detection use the EMA calculation introduced for regulation.

Because some configuration need more smoothing into the EMA calculation, the default parameter should be easily updated.
Because the VTHerm configuration process is aleady complex, we need to add this parameters into the optional configuration.yaml introduced with auto regulation feature.

The parameters are:

  1. MAX_ALPHA: a parameter that limits the alpha influence (ir the weight of a measurement point depending of its delay vs the previous one),
  2. halflife: the length of the period in which we consider the old values
  3. precision: the number of digits of precision
@jmcollin78
Copy link
Owner Author

Example of configuration (which correspond to the default configuration):

versatile_thermostat:
    auto_regulation_expert:
        kp: 0.4
        ki: 0.08
        k_ext: 0.0
        offset_max: 5
        stabilization_threshold: 0.1
        accumulated_error_threshold: 50
    short_ema_params:
        max_alpha: 0.5
        halflife_sec: 300
        precision: 2

@jmcollin78 jmcollin78 added enhancement New feature or request developed When development is done and tested P1 Priority 1 labels Dec 1, 2023
jmcollin78 pushed a commit that referenced this issue Dec 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
developed When development is done and tested enhancement New feature or request P1 Priority 1
Projects
None yet
Development

No branches or pull requests

1 participant