-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance temperature regulation when working with internal device temperature #453
Enhance temperature regulation when working with internal device temperature #453
Conversation
Hello @jdeksup , I understand the idea and it could be interesting. It has one important drawback: we should avoid to send to much regulation command (setpoint change) on some equipment like TRV. Else we will drawn the battery very fast. (see some issue relative to this particular point). This threshold have been done to avoid this battery drawn and I fear that your improvement will rollback this feature. Without touching the code, you can do what you want by setting the dtemp threshold to 0, I guess. So it is configurable Vtherm by Vtherm and not forced for every one. |
I understand your point. |
…tion send when using underlying device temperature for offset
7b23a12
to
76c84be
Compare
This seems good. Can you please add a unit test with dtemp equal to 0 to prove the correct behavior ?
in the |
Hi, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @jdeksup
Hi,
I use Versatile thermostat from several weeks and really appreciate it to regulate my climate devices that have a bad thermal regulation because of the position of the sensor. Thank you for your big work on this.
I suggest a small adjustment : a behavior that prevents the system from forgetting the regulation when using the device's internal temperature as an offset.
Although the regulation itself remains unchanged, variations in the device's internal temperature necessitate adjustments to the target temperature to maintain effective regulation. This code modification specifically bypasses the forget mechanism for minor adjustments, while the forget mechanism based on duration is still maintained.
Here is an history of the underlying climate before :
![image](https://private-user-images.githubusercontent.com/9569564/324803683-f77b2cb6-c694-4b92-a6c2-09d96fb2a273.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjM5ODAxNDMsIm5iZiI6MTcyMzk3OTg0MywicGF0aCI6Ii85NTY5NTY0LzMyNDgwMzY4My1mNzdiMmNiNi1jNjk0LTRiOTItYTZjMi0wOWQ5NmZiMmEyNzMucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDgxOCUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA4MThUMTExNzIzWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9MzFiZDg5ODc0NWE0MWZkZDAyNTcxMjgxNDBiZjIyYWJhNmI3NDVmNjllM2ZjNGE3ODkyZjY2ZGFlOGYxMWZmZCZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.WgMdXDb1-tbB8xWRgWOmWInEJ9br9rmow-MQbjKRkDM)
![image](https://private-user-images.githubusercontent.com/9569564/324802193-95a7e679-d4e2-42f7-a428-55b254de3884.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjM5ODAxNDMsIm5iZiI6MTcyMzk3OTg0MywicGF0aCI6Ii85NTY5NTY0LzMyNDgwMjE5My05NWE3ZTY3OS1kNGUyLTQyZjctYTQyOC01NWIyNTRkZTM4ODQucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDgxOCUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA4MThUMTExNzIzWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9MmRlZjQ2YmI2NDM1NjliNTc1OTRkNGRlZjgzNTM3MGRmNTczNzQxMjU5ZTQ0YjUxNmQ2NDdiOGEyZTQ0MzI2NyZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.YHqgOYQvtTF8nNHYBFChjSvx-ICuPiU8D0jmgPtlMAg)
and after (with 2 minutes of interval which is fast) :