Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run the tests with neo4j 2.2.0 and NEO4J_URL env variable #72

Merged
merged 1 commit into from
Apr 13, 2015

Conversation

wwwdata
Copy link
Contributor

@wwwdata wwwdata commented Mar 30, 2015

The tests are now running with the latest neo4j version. They will now only run if a environment variable is set. Everybody can run the tests now in his own environment. They previously only connected to localhost

For proper test builds, travis must be configured with 1 Environment variable now, which are

  • NEO4J_URL

also make backend URL configurable in the tests with NEO4J_URL env
variable and fix tests.
@wwwdata
Copy link
Contributor Author

wwwdata commented Apr 1, 2015

My adding of username/password was unnecessary because go automatically adds basic headers when including user:pass@domain in the url. I still let this PR open, because the tests are now run against neo4j 2.2.0 and are all working.

@wwwdata wwwdata changed the title add username and passwort to Connect method, fixes #71 run the tests with neo4j 2.2.0 and NEO4J_URL env variable Apr 1, 2015
jmcvetta added a commit that referenced this pull request Apr 13, 2015
run the tests with neo4j 2.2.0 and NEO4J_URL env variable
@jmcvetta jmcvetta merged commit 9878497 into jmcvetta:master Apr 13, 2015
@jmcvetta
Copy link
Owner

Thanks for contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants