ServiceInfo of unreachable devices gets removed with expiration of IP address. #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 26, 2017
ViToni
changed the title
Signed-off-by: Victor Toni <victor.toni@gmail.com>
|
Running the unit tests results in Besides these failures: If you are fixing bugs in the implementation here, is there a chance you could also add a regression tests for your fix? |
|
@spearway As this is a deeper change in the core code: Any chance you could have a glance over the changes whether you see anything dangerous in here? |
Signed-off-by: Victor Toni <victor.toni@gmail.com>
Signed-off-by: Victor Toni <victor.toni@gmail.com>
|
I removed the last commit which was the one resulting in the failing test although it seems unclear to me yet why it fails... The remaining commits were checked individually and pass the existing checks. Regarding the test I will check back how the desired behaviour could be tested. |
|
@ViToni Unfortunately, I still see one failing test: Could you please check? |
|
I am using Win10 / java version "1.8.0_121" / Apache Maven 3.3.9 and cannot reproduce the issue. The original PR had 4 commits of which the last one let the tests fail. This commit has been removed so that the PR consists out of 3 commits. Now I cannot reproduce failing test anymore. Below you can see how I did the testing. |
|
I am sorry, you are right - I must have had a dirty checkout. Just re-run everything and tests are green - thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a device loses its connection the device will not be removed until its PTR record expires (75min).
This PR will change this behaviour insofar that it removes the service when the last of its IP (v4/v6) has expired, means the device is no longer reachable.