Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#71) initials of integration for SnoopPrecompile #72

Merged
merged 6 commits into from
Mar 13, 2023
Merged

(#71) initials of integration for SnoopPrecompile #72

merged 6 commits into from
Mar 13, 2023

Conversation

jbytecode
Copy link
Contributor

This is the initial adaptation of SnoopPrecompile.

@jbytecode
Copy link
Contributor Author

It is interesting that the tests were not passed.

@jmejia8
Copy link
Owner

jmejia8 commented Mar 13, 2023

Did work on your Julia distribution?

@jbytecode
Copy link
Contributor Author

yes, of course, in 1.9.rc1

@jbytecode
Copy link
Contributor Author

Test Summary:   | Pass  Total     Time
Multi objective |  118    118  1m14.8s
Test Summary: | Pass  Total  Time
Combinatorial |    4      4  9.2s
Test Summary:                          | Pass  Total  Time
DecisionMaking: Compromise Programming |    6      6  1.9s
Test Summary:       | Pass  Total  Time
DecisionMaking: ROI |    4      4  1.0s
Test Summary:         | Pass  Total   Time
DecisionMaking: JMcDM |   34     34  14.2s
Test Summary:     | Pass  Total  Time
Initial Solutions |   87     87  3.1s
     Testing Metaheuristics tests passed 

(Metaheuristics) pkg> 

@jmejia8
Copy link
Owner

jmejia8 commented Mar 13, 2023

Maybe, It is time to upgrade Julia (>= 1.8) in the test environment

due to

https://discourse.julialang.org/t/ann-new-package-snoopprecompile/84778

@jbytecode
Copy link
Contributor Author

Can we test it by upgrading the version in only github workflow?

@jmejia8
Copy link
Owner

jmejia8 commented Mar 13, 2023

Of course. Julia 1.5 is not longer maintained.

@jbytecode
Copy link
Contributor Author

Last time I used v1.5.2 was Sep or Oct, 2020

@jbytecode
Copy link
Contributor Author

even v1.8 is not enough to get tests passed :(

@jbytecode
Copy link
Contributor Author

nightly builds seem to work..

@jmejia8
Copy link
Owner

jmejia8 commented Mar 13, 2023

I see.. BTW, the errors comes due to

Calling eval at that level is breaking the pre-compilation stage.

@jbytecode
Copy link
Contributor Author

yes, the problem may not be about versioning.

@jmejia8
Copy link
Owner

jmejia8 commented Mar 13, 2023

We need to refactor this function

function get_problem(problem)

before proceed.

@jmejia8
Copy link
Owner

jmejia8 commented Mar 13, 2023

The original PR is now passing the tests. Thank you!

@jmejia8 jmejia8 merged commit 6ca3910 into jmejia8:master Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants