Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make use of efficient Julia sparse outer products #4

Closed
jmert opened this issue Dec 8, 2017 · 0 comments · Fixed by #28
Closed

Make use of efficient Julia sparse outer products #4

jmert opened this issue Dec 8, 2017 · 0 comments · Fixed by #28

Comments

@jmert
Copy link
Owner

jmert commented Dec 8, 2017

Currently I have some non-general code for computing outer products of sparse vectors, but the functionality should really exist in Julia itself. I've opened JuliaLang/julia#24980 to work on this.

If[/when] accepted, the functionality should be copied/backported as a version-limited code block here to support the necessary computations even on julia v0.6.
jmert added a commit that referenced this issue Jul 8, 2020
@jmert
Make use of fast sparse outer products from Julia (closes #4)
93cdc0e 
The feature was added to Julia in time for v1.2 in JuliaLang/julia#24980,
so get rid of the custom `outer()` method here and rewrite `quadprod()`
in terms of just standard matrix methods. Julia v1.2 is the
minimum-supported version at this point, so no need to worry about
backporting the functionality.

In the future, this function may yet still go away since the
implementation is nearly trivial at this point, but that can be a
follow-up PR.
jmert added a commit that referenced this issue Jul 8, 2020
@jmert
Make use of fast sparse outer products from Julia (closes #4)
5e693c9 
The feature was added to Julia in time for v1.2 in JuliaLang/julia#24980,
so get rid of the custom `outer()` method here and rewrite `quadprod()`
in terms of just standard matrix methods. Julia v1.2 is the
minimum-supported version at this point, so no need to worry about
backporting the functionality.

In the future, this function may yet still go away since the
implementation is nearly trivial at this point, but that can be a
follow-up PR.
@jmert jmert mentioned this issue Jul 8, 2020
Merged
@jmert jmert closed this as completed in #28 Jul 8, 2020
jmert added a commit that referenced this issue Jul 8, 2020
@jmert
Make use of fast sparse outer products from Julia (closes #4)
fed2823 
The feature was added to Julia in time for v1.2 in JuliaLang/julia#24980,
so get rid of the custom `outer()` method here and rewrite `quadprod()`
in terms of just standard matrix methods. Julia v1.2 is the
minimum-supported version at this point, so no need to worry about
backporting the functionality.

In the future, this function may yet still go away since the
implementation is nearly trivial at this point, but that can be a
follow-up PR.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Reorganize numerical helper functions jmert/CMB.jl
1 participant
@jmert