Import StaticArrays.SVector into docs to have type-only printing #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids a doctest failures from mismatched owner modules depending on the version of StaticArrays which is loaded. For StaticArrays < v1.5, the fully-qualified type is `StaticArrays.SVector`, but starting with v1.5 the type definition moved to `StaticArraysCore.SVector`. By importing explicitly from StaticArrays into the environment, the printing system skips the module component and therefore we don't see any discrepancy in printing no matter which version of Julia + StaticArrays is being used.
Codecov Report
@@ Coverage Diff @@
## master #72 +/- ##
=======================================
Coverage 98.27% 98.27%
=======================================
Files 11 11
Lines 984 984
=======================================
Hits 967 967
Misses 17 17
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids a doctest failures from mismatched owner modules depending
on the version of StaticArrays which is loaded. For StaticArrays < v1.5,
the fully-qualified type is
StaticArrays.SVector, but starting withv1.5 the type definition moved to
StaticArraysCore.SVector.By importing explicitly from StaticArrays into the environment, the
printing system skips the module component and therefore we don't see
any discrepancy in printing no matter which version of
Julia + StaticArrays is being used.