Add support for custom functions #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This moves the cyclic dependency between functions and interpreters to expref nodes and functions. This makes it easier to create custom function runtime classes as they now have no instance state.
Closed
|
Wow thanks! This will be really useful! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for custom functions. It has these changes:
custom_functionsto theOptionsclass. This is how you can provide custom functions to use.interpreterin theFunctionsclass. This was originally added to invokeexprefs, but the cyclic dependency between interpreter and functions made initialization awkward. Each expref now has a reference to the interpreter. This may need some rethinking if other backends besides a tree interpreter are added.Functionsclass. Instead this has all been moved out into a metaclass. The benefit here is that you can subclass from this base class and theFUNCTION_TABLEwill be automatically populated for you. This makes the extension API more straightforward.I've added an example in the README (and a testcase) that shows how you can add custom functions.
Closes #100