Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

None to NoneType #129

Closed
wants to merge 1 commit into from
Closed

None to NoneType #129

wants to merge 1 commit into from

Conversation

ophiry
Copy link

@ophiry ophiry commented May 9, 2017

bugfix: the type of None should be NoneType instead of None

bugfix: the type of None should be NoneType instead of None
@codecov-io
Copy link

Codecov Report

Merging #129 into develop will decrease coverage by 0.59%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop     #129     +/-   ##
==========================================
- Coverage    97.27%   96.68%   -0.6%     
==========================================
  Files           13       13             
  Lines         1431     1447     +16     
==========================================
+ Hits          1392     1399      +7     
- Misses          39       48      +9
Impacted Files Coverage Δ
jmespath/functions.py 99.49% <ø> (ø) ⬆️
jmespath/compat.py 76.78% <0%> (-13.22%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef36ae7...1691d82. Read the comment docs.

@jamesls
Copy link
Member

jamesls commented May 15, 2017

Not sure why codecov is complaining.

Could you add a test for this change that demonstrates the issue? Once we have that I'll go ahead and merge. Thanks.

@gmega
Copy link
Contributor

gmega commented Sep 5, 2017

Hi there @ophiry @jamesls: I've written the test so that we can see this change merged. :-) I don't see an easy way to integrate my changes in this pull request though. Should I open a new one? Thanks.

@jamesls
Copy link
Member

jamesls commented Sep 5, 2017

@gmega Feel free to open a new one. Thanks!

@jamesls
Copy link
Member

jamesls commented Sep 12, 2017

Fixed in #145

@jamesls jamesls closed this Sep 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants