Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use list for random.sample since using a set has been deprecated since Python 3.9 #217

Merged
merged 1 commit into from
Mar 16, 2022
Merged

Use list for random.sample since using a set has been deprecated since Python 3.9 #217

merged 1 commit into from
Mar 16, 2022

Conversation

tirkarthi
Copy link
Contributor

Fixes #216

@simonw
Copy link

simonw commented Mar 19, 2021

That failure happened on Python 3.3:

  Downloading https://files.pythonhosted.org/packages/05/d9/6eebe19d46bd05360c9a9aae822e67a80f9242aabbfc58b641b957546607/typing-3.7.4.3.tar.gz (78kB)

    100% |████████████████████████████████| 81kB 11.2MB/s 

    Complete output from command python setup.py egg_info:

    ERROR: You need Python 2.7 or 3.4+ to install the typing package.

Copy link
Member

@jamesls jamesls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

We can add a follow up PR to simplify this even more. Now that we're > 3.6, we can rely on the fact that dicts are ordered to just delete the first N entries (or even just the first entry) to clear up the cache.

@jamesls jamesls merged commit 98ef113 into jmespath:develop Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

deprecation warning on python 3.9
3 participants