Merge pull request #24 from iconara/optimize-falsey

Simplify and optimize Util.falsey?
jmespath · Jul 7, 2016 · dc01514 · dc01514
2 parents e164f0b + e3479a7
commit dc01514
Showing 1 changed file with 3 additions and 7 deletions.
diff --git a/lib/jmespath/util.rb b/lib/jmespath/util.rb
@@ -8,15 +8,11 @@ class << self
       #   https://github.com/jmespath/jmespath.site/blob/master/docs/proposals/improved-filters.rst#and-expressions-1
       #
       def falsey?(value)
-        value.nil? ||
-        value === false ||
-        value == '' ||
-        value == {} ||
-        value == [] ||
-        (value.respond_to?(:entries) && value.entries.compact.empty?)
+        !value ||
+        (value.respond_to?(:empty?) && value.empty?) ||
+        (value.respond_to?(:entries) && !value.entries.any?)
         # final case necessary to support Enumerable and Struct
       end
-
     end
   end
 end