Specify explicit error type for all error scenarios #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastien-rosset
changed the title
This was referenced Mar 30, 2023
|
|
jamesls
reviewed
Mar 24, 2023
| @@ -348,7 +348,7 @@ Slice expressions adhere to the following rules: | |||
| * If no stop position is given, it is assumed to be the length of the array if | |||
| the given step is greater than 0 or 0 if the given step is less than 0. | |||
| * If the given step is omitted, it it assumed to be 1. | |||
| * If the given step is 0, an error MUST be raised. | |||
| * If the given step is 0, an ``invalid-value`` error MUST be raised. | |||
There was a problem hiding this comment.
EDIT: never mind, while the spec never specified the error type, the compliance tests did so I'm ok with updating the spec here.
jamesls
added a commit
that referenced
this pull request
Mar 24, 2023
PR #115 * error-handling: Use explicit error types
|
Rebased and merged in 98abdcf, thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the wording of the spec to state the specific error type in all error scenarios.
I have found 34 occurrences of the word "error" in the spec. In most cases, the spec indicates the exact type of error, e.g.,
invalid-type,unknown-function,invalid-arity. However, there are three occurrences when no explicit error type is mentioned.In two cases, I think the right error type is
invalid-type. In the third case (Slices section), I'm not sure what the error type should be. Maybeinvalid-value, but it's not specified anywhere in the spec (I see only three error types defined). Related to this, I have raised #116 to add a section for error handling.