Fixed leak of "hostCookie" into global scope. (Thanks Kris Maglione)

Bump version to 1.3.4
jmhobbs · Feb 7, 2011 · 8675eb7 · 8675eb7
1 parent 08c3a2b
commit 8675eb7
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 1 deletion.
diff --git a/CHANGELOG b/CHANGELOG
@@ -1,3 +1,7 @@
+# 1.3.4 (Unreleased) [HEAD]
+
+Fixed leak of "hostCookie" into global scope. (Thanks Kris Maglione)
+
 # 1.3.3 (2011-02-01) [04640d7]
 
 Added many new cookies (Thanks Jim @ PrivacyChoice)

diff --git a/firefox/chrome/content/beef-taco.js b/firefox/chrome/content/beef-taco.js
@@ -77,6 +77,7 @@ com.github.jmhobbs.beef_taco.OptOut = function () {
 
 	for( var host in com.github.jmhobbs.beef_taco.cookies ) {
 		var hostCookies = com.github.jmhobbs.beef_taco.cookies[host];
+		var hostCookie = null;
 		for each ( hostCookie in hostCookies ) {
 			cm.add(
 				host,             // host
@@ -139,6 +140,7 @@ com.github.jmhobbs.beef_taco.CookieListener = {
 				var cookie = subject.QueryInterface( Components.interfaces.nsICookie2 );
 				var host = cookie.host;
 				var hostCookies = com.github.jmhobbs.beef_taco.cookies[host];
+				var hostCookie = null;
 				for each ( hostCookie in hostCookies ) {
 					if( hostCookie.name == cookie.name ) {
 						com.github.jmhobbs.beef_taco.SetCookie( host, hostCookie );

diff --git a/firefox/install.rdf b/firefox/install.rdf
@@ -2,7 +2,7 @@
 <RDF xmlns="http://www.w3.org/1999/02/22-rdf-syntax-ns#" xmlns:em="http://www.mozilla.org/2004/em-rdf#">
   <Description about="urn:mozilla:install-manifest">
     <em:id>john@velvetcache.org</em:id>
-    <em:version>1.3.3</em:version>
+    <em:version>1.3.4</em:version>
     <em:type>2</em:type>
     <em:name>Beef Taco (Targeted Advertising Cookie Opt-Out)</em:name>
     <em:aboutURL>chrome://beef-taco/content/about.xul</em:aboutURL>