Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: May we have the feature to make the filter serializable ? #3

Closed
purplepapa opened this issue Oct 24, 2014 · 3 comments

Comments

@purplepapa
Copy link

Hi Jeff,

We need to persist it it to local storage or work with redis , could it be possible to add such feature?
There is some reference projects as follows:
1.https://github.com/Baqend/Orestes-Bloomfilter for redis
2.https://github.com/Cue/greplin-bloom-filter for file storage

Best regards,
Kevin Wen

@jmhodges
Copy link
Owner

No, that is outside the scope of this demo. Just write your own to do whatever.

(However, I would argue that putting this in redis is an incredibly bad idea since it will be full of race conditions. It will never work like you think it should.)

@purplepapa
Copy link
Author

Thanks anyway.

@DivineTraube
Copy link

Hi, you are wrong about Redis. It is absolutely possible to do this in a thread-safe and consistent manner, as can be seen in our Bloom filter implementation. Commutativity, atomic MULTI blocks and optimistic locking in Redis make this perfectly possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants