added some legendary quotes #4
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Return-1
reviewed
Oct 15, 2018
src/index.js
Outdated
| 'Writing tests takes x3 time than writing actual code.', | ||
| 'We need you to work on features. Not performance.', | ||
| 'Please do not worry a lot about quality. This is a prototype.', | ||
| 'Hurry up. This is just a proof of concept.', |
There was a problem hiding this comment.
I think this one is similar to the one above. Otherwise its all good with me. @jmike ?
There was a problem hiding this comment.
Agreed, @cherouvim line #15 is quite similar to line #14.
Would you agree to remove it from the PR?
jmike
requested changes
Oct 16, 2018
src/index.js
Outdated
| 'Writing tests takes x3 time than writing actual code.', | ||
| 'We need you to work on features. Not performance.', | ||
| 'Please do not worry a lot about quality. This is a prototype.', | ||
| 'Hurry up. This is just a proof of concept.', |
There was a problem hiding this comment.
Agreed, @cherouvim line #15 is quite similar to line #14.
Would you agree to remove it from the PR?
src/index.js
Outdated
| 'We need you to work on features. Not performance.', | ||
| 'Please do not worry a lot about quality. This is a prototype.', | ||
| 'Hurry up. This is just a proof of concept.', | ||
| 'Can we worry about security at a later phase?' |
There was a problem hiding this comment.
@cherouvim suggestion to simplify: "Can we worry about security later?"
What do you think?
cherouvim
commented
Oct 16, 2018
src/index.js
Outdated
| 'Writing tests takes x3 time than writing actual code.', | ||
| 'We need you to work on features. Not performance.', | ||
| 'Please do not worry a lot about quality. This is a prototype.', | ||
| 'Hurry up. This is just a proof of concept.', |
src/index.js
Outdated
| 'We need you to work on features. Not performance.', | ||
| 'Please do not worry a lot about quality. This is a prototype.', | ||
| 'Hurry up. This is just a proof of concept.', | ||
| 'Can we worry about security at a later phase?' |
jmike
approved these changes
Oct 17, 2018
|
Accepted and merged manually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.