Integrate GitHub CI and bump Symfony requirement #24
Conversation
jmikola
force-pushed
the
pr23-ci
branch
2 times, most recently
from
ead50b4
to
8f45085
Compare
| echo "::endgroup::" | ||
|
|
||
| - name: "Run PHPUnit" | ||
| run: "./vendor/bin/simple-phpunit -v" |
There was a problem hiding this comment.
Why is the verbose flag used?
There was a problem hiding this comment.
This was out of habit, as we use this in mongo-php-library. It doesn't add much to the output for a successful build (just PHP runtime and PHPUnit config file IIRC), but the output is more helpful when a test actually fails.
| composer update --no-interaction --no-progress ${{ matrix.composer-args }} | ||
| echo "::endgroup::" | ||
| echo "::group::install phpunit" | ||
| ./vendor/bin/simple-phpunit install |
There was a problem hiding this comment.
Not sure if this line does anything.
This is the result I'm getting in my dev:
./vendor/bin/simple-phpunit -v install; echo $?"
PHPUnit 9.4.4 by Sebastian Bergmann and contributors.
Cannot open file "install".
0
There was a problem hiding this comment.
PHPUnit will installed lazily whenever this script is invoked. For CI purposes, it's preferable to do this during a setup stage instead of the actual test stage.
You'd have to parse through simple-phpunit.php to make sense of this, but "install" is specially ignored by the script so that you can invoke this once without running any tests. It cannot be mixed with other PHPUnit command line args/options, such as -v.
jmikola
changed the title
Depends on #23
cc: @tachnik