Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken icon in popup menu for BPM actions and other places #2004

Closed
tmusin opened this issue Jul 12, 2023 · 1 comment
Closed

Broken icon in popup menu for BPM actions and other places #2004

tmusin opened this issue Jul 12, 2023 · 1 comment
Assignees
@dtaimanov @rusiaikinat
Labels
in: bpm size: S type: bug Something isn't working ver: 1 Jmix version 1.x
Projects
Release 1.5
Milestone
1.5.4

Comments

@tmusin
Copy link

tmusin commented Jul 12, 2023 •
edited by dtaimanov

From forum

Problem

  1. Create project with the custom theme.
  2. Set jmix.ui.showIconsForPopupMenuActions=true to the theme properties.
  3. Run project, create and start BPM process.
  4. Go to the MyTasks screen, call popup menu from the assigned task item.

AR: Action appears with the broken icon.

Also there is no icon for the "Upload BPMN XML" button in the Process Definitions screen.

Test project to reproduce (just open "My tasks" and call popup menu):
BpmIconTest.zip

Solution:

Replace "icon/xyz.png" with font-icon name according to jmix-projects/jmix-old#591

QA Notes:

Beside two icons mentioned in description, icons has been updated in screens:

  • [cuba module] Scheduled execution browse
  • [cuba module] Scheduled task browse
  • [cuba module] Scheduled task edit
  • Pivot table excel action
  • Filter select and save actions
  • Snapshot diff viewer compare button
@tmusin tmusin added the in: bpm label Jul 12, 2023
@gorbunkov gorbunkov added type: bug Something isn't working size: S labels Jul 17, 2023
@dtaimanov dtaimanov added the ver: 1 Jmix version 1.x label Jul 19, 2023
@dtaimanov dtaimanov added this to Backlog in Release 1.5 via automation Jul 20, 2023
@gorbunkov gorbunkov moved this from Backlog to Next in Release 1.5 Aug 21, 2023
@gorbunkov
Copy link
Contributor

Probably we should replace icon file name with the icon name.

@dtaimanov dtaimanov moved this from Next to In progress in Release 1.5 Aug 28, 2023
dtaimanov added a commit that referenced this issue Aug 29, 2023
@dtaimanov
Broken icon in popup menu for BPM actions #2004
86bde38
dtaimanov added a commit that referenced this issue Aug 29, 2023
@dtaimanov
Broken icon in popup menu for BPM actions #2004
5c40341
@dtaimanov dtaimanov changed the title Broken icon in popup menu for BPM actions Broken icon in popup menu for BPM actions and other places Aug 29, 2023
@dtaimanov dtaimanov moved this from In progress to QA in Release 1.5 Aug 29, 2023
dtaimanov added a commit that referenced this issue Aug 29, 2023
@dtaimanov
Broken icon in popup menu for BPM actions. Fix tests #2004
44192db
@rusiaikinat rusiaikinat self-assigned this Sep 10, 2023
Release 1.5 automation moved this from QA to Done Sep 12, 2023
@gorbunkov gorbunkov added this to the 1.5.4 milestone Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dtaimanov dtaimanov

@rusiaikinat rusiaikinat

Labels
in: bpm size: S type: bug Something isn't working ver: 1 Jmix version 1.x
Projects
Release 1.5
  
Done
Milestone
1.5.4
Development

No branches or pull requests
4 participants
@gorbunkov @dtaimanov @tmusin @rusiaikinat