Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to define prefix and suffix components in XML #2096

Closed
8 tasks done
glebfox opened this issue Jul 28, 2023 · 1 comment · Fixed by #2130
Closed
8 tasks done

Ability to define prefix and suffix components in XML #2096

glebfox opened this issue Jul 28, 2023 · 1 comment · Fixed by #2130
Assignees
Milestone

Comments

@glebfox
Copy link
Contributor

glebfox commented Jul 28, 2023

E.g.

<textField id="nameField" property="name">
    <prefix>
        <icon icon="QUESTION"/>
    </prefix>
    <suffix>
        <button icon="PENCIL"/>
    </suffix>
</textField>

Plan:

  • Component research
  • layout.xsd
  • Loader support
  • XML load test
  • ViewControllerDependencyInjector support (perfomance issue: to be discussed???)
  • Create Jmix Studio issue MetaAnnotations support (JST-4191)
    • + add kit meta annotations (probably need to changed)
  • Manual test in runtime

To be discussed:

DrawerToggle has an interesting behavior
Do we really need it?

XML:

        <drawerToggle icon="SUN_RISE">
            <prefix>
                <button id="prefixButton3" themeNames="tertiary-inline" icon="VAADIN_H"/>
            </prefix>
            <suffix>
                <button id="suffixButton3" themeNames="tertiary-inline" icon="VAADIN_V"/>
            </suffix>
        </drawerToggle>

Runtime:
image

DOM:
image

Solution: remove drawerToggle support

@rusiaikinat
Copy link

Jmix version: 2.1.999-SNAPSHOT (Kotlin, Java)
Jmix Studio plugin version: 2.1.SNAPSHOT5430-232
IntelliJ version: IntelliJ IDEA 2023.2 (Ultimate Edition)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants