Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polish layout of security system views #2519

Closed
glebfox opened this issue Nov 24, 2023 · 2 comments
Closed

Polish layout of security system views #2519

glebfox opened this issue Nov 24, 2023 · 2 comments
Assignees
Labels
breaking changes Fix brings breaking changes in code or behavior in: flowui size: S
Milestone

Comments

@glebfox
Copy link
Contributor

glebfox commented Nov 24, 2023

Feature Description

Security system views have ugly layout, e.g.

ResourceRoleModelDetailView and RowLevelRoleModelDetailView

Action buttons are go beyond view boundaries if not enough space
Screenshot 2023-11-24 at 11 56 28

This can be fixed by making actions box fixed position, e.g.:

Screenshot 2023-11-24 at 11 58 27

RoleAssignmentView

Tables don't occupy the full height

Screenshot 2024-01-22 at 00 35 29

and can be collapsed for no reason

Screenshot 2024-01-22 at 00 34 23
@glebfox glebfox added the triage Issue is waiting for triage label Nov 24, 2023
@glebfox glebfox self-assigned this Nov 24, 2023
@gorbunkov gorbunkov added candidate Possible candidate for future releases size: S in: flowui and removed triage Issue is waiting for triage candidate Possible candidate for future releases labels Dec 1, 2023
@glebfox glebfox changed the title Polish layout of system views Polish layout of security system views Jan 21, 2024
@glebfox glebfox added the breaking changes Fix brings breaking changes in code or behavior label Jan 21, 2024
@glebfox
Copy link
Contributor Author

glebfox commented Jan 21, 2024

Layouts of security system views have been changed, so may lead to problems if someone extended them.

For QA: Check that the following views are still usable:

  • ResourceRoleModelDetailView - Security > Resource roles, create/edit a role
  • RowLevelRoleModelDetailView - Security > Row-level roles, create/edit a role
  • RoleAssignmentView - Users, select a user > Role assignments

@konyashkina
Copy link

konyashkina commented Feb 7, 2024

Tested on
Jmix version: 2.2.999-SNAPSHOT
Jmix Studio plugin version: 2.2.SNAPSHOT6050-233
IntelliJ version: IntelliJ IDEA 2023.3.3

@gorbunkov gorbunkov added this to the 2.2.0 milestone Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking changes Fix brings breaking changes in code or behavior in: flowui size: S
Projects
Status: Done
Development

No branches or pull requests

3 participants