Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MainView] Support for initial layout (2213) #2420

Merged
merged 1 commit into from
Nov 1, 2023

Conversation

glebfox
Copy link
Contributor

@glebfox glebfox commented Oct 31, 2023

See: #2213

@glebfox glebfox requested a review from Flaurite October 31, 2023 07:05
@glebfox glebfox self-assigned this Oct 31, 2023
@@ -0,0 +1,39 @@
<?xml version="1.0" encoding="UTF-8" standalone="no"?>
<mainView xmlns="http://jmix.io/schema/flowui/main-view"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Main view already exists in tests: TestMainView. May be we can move testing code in it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw this but decided against it so as not to affect other views.

@glebfox glebfox merged commit 11ee7e2 into master Nov 1, 2023
@glebfox glebfox deleted the feature/2213-main-view-initial-layout branch November 1, 2023 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants