Buffer upstream responses in handle_response #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This implementation should be more reasonable, thanks! Please format. |
timfennis
force-pushed
the
feature/buffer-and-append-streams
branch
from
53052b0
to
6b0200a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So, this isn't a serious pull request because there are probably better ways of doing this. We ran into an issue using this library to talk to php-fpm where PHP likes to send its responses in multiple chunks. The current implementation only gives us the last chunk to work with.
Another way to work around this is using the new
execute_streamfunction on client but it seems to me like the regularexecutemethod should have a better default.Anyways I hope this PR is an effective way to communicate the issue we're having and helps you potentially fix this.