Updates group functions to work better for small sizes #41

jbeker · 2024-07-03T14:47:48Z

I updated group_members and balance_groups to work better when there are less than 2 * MAX_GROUP_SIZE members.

I also updated the message for group invites to not say "both" which implies a pair of people.

jmkoni · 2024-07-03T15:36:54Z

app/models/slack_message.rb

@@ -76,7 +76,7 @@ def group_message(group:)
        block_id: "group_introduction",
        text: {
          type: "mrkdwn",
-          text: ":wave: Hi #{group_usernames}! You've both been grouped up for a coffee chat from <##{ENV["GROUPS_CHANNEL"]}>! Find a time to meet and have fun!"
+          text: ":wave: Hi #{group_usernames}! You've been grouped up for a coffee chat from <##{ENV["GROUPS_CHANNEL"]}>! Find a time to meet and have fun!"


good catch!

Remove hard coded date, use scheduler

Style

Make text appropriate for group

This reverts commit adcbf80.

This reverts commit e8fec2f. # Conflicts: # app/jobs/create_groups_job.rb

jmkoni · 2024-07-03T16:41:08Z

Well at least I wrote some tests... but they are a bit brittle!

       Diff:
       @@ -1,7 +1,7 @@
       [{:block_id=>"group_introduction",
         :text=>
           {:text=>
       -     ":wave: Hi <@123>, <@456>, and <@789>! You've both been grouped up for a coffee chat from <#C123>! Find a time to meet and have fun!",
       +     ":wave: Hi <@123>, <@456>, and <@789>! You've been grouped up for a coffee chat from <#C123>! Find a time to meet and have fun!",
           :type=>"mrkdwn"},
          :type=>"section"}]
# ./spec/models/slack_message_spec.rb:35:in `block (2 levels) in <top (required)>'
     ```

jmkoni approved these changes Jul 3, 2024

View reviewed changes

jbeker added 7 commits July 3, 2024 12:19

Update create_groups_job.rb

203d7b1

Remove hard coded date, use scheduler

Update create_groups_job.rb

bd4ef01

Style

Update slack_message.rb

0c29967

Make text appropriate for group

Revert "Update create_groups_job.rb"

84aaf0f

This reverts commit adcbf80.

Rework group creation and balancing to work with small groups.

4169838

Put the first Monday test back in

88ce4a0

This reverts commit e8fec2f. # Conflicts: # app/jobs/create_groups_job.rb

Turn on scheduler

1124ece

jbeker force-pushed the main branch from 5ccb777 to 1124ece Compare July 3, 2024 16:22

Get tests passing

62b5793

jmkoni merged commit 31fb575 into jmkoni:main Jul 3, 2024
2 of 3 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Updates group functions to work better for small sizes #41

Updates group functions to work better for small sizes #41

jbeker commented Jul 3, 2024

jmkoni Jul 3, 2024

jmkoni commented Jul 3, 2024

Updates group functions to work better for small sizes #41

Updates group functions to work better for small sizes #41

Conversation

jbeker commented Jul 3, 2024

jmkoni Jul 3, 2024

Choose a reason for hiding this comment

jmkoni commented Jul 3, 2024