Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Vcs and Commit models #40

Merged
merged 1 commit into from
Nov 29, 2021
Merged

Add Vcs and Commit models #40

merged 1 commit into from
Nov 29, 2021

Conversation

Airmanbzh
Copy link
Contributor

A PR to add models for VSC and commit when we get all pipelines

I also fixed a typo in Error model

@jmleroux
Copy link
Owner

They are two BC breaks in this PR.
Let me think about it 🤔

@jmleroux jmleroux self-assigned this Nov 29, 2021
jmleroux
jmleroux approved these changes Nov 29, 2021
View reviewed changes
Copy link
Owner

@jmleroux jmleroux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go, we will tag a v4 because of bc breaks

@jmleroux jmleroux merged commit a23b2ae into jmleroux:master Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmleroux jmleroux jmleroux approved these changes

Assignees

@jmleroux jmleroux

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Airmanbzh @jmleroux