fix celt json stats when there are no errors

jmlopez-rod · Oct 7, 2021 · 669bc54 · 669bc54
1 parent 90ad6d5
commit 669bc54
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 6 deletions.
diff --git a/packages/python/m/ci/celt/core/io.py b/packages/python/m/ci/celt/core/io.py
@@ -174,12 +174,15 @@ def project_stats_json(
         ],
         key=cmp_to_key(_compare_rule_items),
     )
-    buffer.extend([
-        f'    "{rule_id}": {rule.found},'
-        for rule_id, rule in key_rule[:-1]
-    ])
-    rule_id, rule = key_rule[-1]
-    buffer.append(f'    "{rule_id}": {rule.found}')
+
+    if key_rule:
+        buffer.extend([
+            f'    "{rule_id}": {rule.found},'
+            for rule_id, rule in key_rule[:-1]
+        ])
+        rule_id, rule = key_rule[-1]
+        buffer.append(f'    "{rule_id}": {rule.found}')
+
     buffer.extend([
         '  }',
         '}',

diff --git a/packages/python/tests/ci/celt/test_processors.py b/packages/python/tests/ci/celt/test_processors.py
@@ -132,6 +132,16 @@ def test_eslint_no_errors(self):
         assert_str_has(eslint.to_str(project), [
             'no errors found'
         ])
+        # test json stats
+        json_stats = eslint.stats_json(project)
+        expected = """
+            {
+              "allowedEslintRules": {
+              }
+            }
+        """
+        self.assertEqual(json_stats, inspect.cleandoc(expected))
+
 
     def test_eslint_no_errors_reduce(self):
         eslint = _post_processor('eslint')